feat: add Transform::ProjectStrict #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Dec 4, 2025
| TEST_F(PredicateTest, BoundUnaryPredicateTestIsNull) { | ||
| ICEBERG_ASSIGN_OR_THROW(auto is_null_pred, Expressions::IsNull("name")->Bind( | ||
| *schema_, /*case_sensitive=*/true)); | ||
| ICEBERG_UNWRAP_OR_FAIL(auto is_null_pred, Expressions::IsNull("name")->Bind( |
Member
There was a problem hiding this comment.
TBH, I think we should remove ICEBERG_UNWRAP_OR_FAIL in favor of ICEBERG_ASSIGN_OR_THROW because the former one cannot be used in functions with return type.
| std::unreachable(); | ||
| } | ||
|
|
||
| Result<std::unique_ptr<UnboundPredicate>> Transform::ProjectStrict( |
Member
There was a problem hiding this comment.
Transform::ProjectStrict looks so similar to Transform::Project with the only difference being the calls to ProjectionUtil. Perhaps we can use template to dispatch it?
Member
There was a problem hiding this comment.
After trying it by myself, I don't think this can help reduce duplicate lines. Ignore the above comment.
wgtmac
reviewed
Dec 4, 2025
wgtmac
force-pushed
the
transform_strict_project
branch
from
ceeda1d to
407abc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.